Add hangdump and crash dump capabilities and options #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into blame-datacollector
…me-datacollector
…et rid of the results dir
pavelhorak
approved these changes
May 14, 2020
|
Wow fantastic. Has the usage of the blame collector in the runsettings file changed? |
|
@ViktorHofer it did not, as far as I am aware. Maybe the dumptype parameter was renamed, but I can make that backwards compatible when consumed from the settings. I am sure we will discover any discrepancies when we integrate this into dotnet/runtime. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First implementation of the hang and crash dump that supports hang dumps on and dotnet core on Windows, and dotnet core 3.1 and newer on linux without any additional tools.
For crash dumps only Windows x64 and x86 are supported, but additionally ProcDump is resolved from PATH, not just PROCDUMP_PATH.
Related issue
Related #1682