Changes to allow special characters in parameter names #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cvpoienaru/vstest into copoiena/special-chars-in-params
nohwnd
reviewed
Jul 13, 2020
...Platform.Common.UnitTests/ExtensionFramework/Utilities/RunSettingsProviderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
nohwnd
reviewed
Aug 31, 2020
...Platform.Common.UnitTests/ExtensionFramework/Utilities/RunSettingsProviderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
...Platform.Common.UnitTests/ExtensionFramework/Utilities/RunSettingsProviderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
...Platform.Common.UnitTests/ExtensionFramework/Utilities/RunSettingsProviderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Common/Utilities/RunSettingsProviderExtensions.cs
Outdated
Show resolved
Hide resolved
|
Hello @cvpoienaru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
nohwnd
reviewed
Sep 1, 2020
| @@ -95,7 +95,7 @@ public static void UpdateRunSettingsNode(this IRunSettingsProvider runSettingsPr | |||
| /// <returns></returns> | |||
| public static Match GetTestRunParameterNodeMatch(this IRunSettingsProvider runSettingsProvider, string node) | |||
| { | |||
| var attrName = $"(?<{AttributeNameString}>\\w+)"; | |||
| var attrName = $"(?<{AttributeNameString}>[\\w.:-]+)"; | |||
There was a problem hiding this comment.
No need to do this but converting this and the line below to $@ string would make it so much easier to read.
nohwnd
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to allow special characters in parameter names
Related issue #2441