Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 32 bit issue #2482

Merged
19 commits merged into from
Jul 16, 2020
Merged

Windows 32 bit issue #2482

19 commits merged into from
Jul 16, 2020

Conversation

Sanan07
Copy link
Contributor

@Sanan07 Sanan07 commented Jul 13, 2020

Description

Fixed issue when running tests on 32 bit Windows. Added more useful warning comments when there are incompatible dlls.

Related issue

@nohwnd
Copy link
Member

nohwnd commented Jul 14, 2020

Please fix the build failure, and the PR name.

@Sanan07 Sanan07 changed the title Dev/sayuzbas/win32 Windows 32 bit issue Jul 14, 2020
@Sanan07 Sanan07 marked this pull request as draft July 14, 2020 09:29
…e of incorrect test running, when we have several test dll, with different build architecture. Expected message was fixed acceptance test.
@Sanan07 Sanan07 marked this pull request as ready for review July 15, 2020 20:48
@ghost
Copy link

ghost commented Jul 16, 2020

Hello @nohwnd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9380017 into microsoft:master Jul 16, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants