Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OS bitness to figure out .NETCore runner architecture #2507

Merged
1 commit merged into from
Aug 4, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Aug 4, 2020

Use the OS bitness to figure out if we should use 32-bit or 64-bit dotnet SDK for AnyCPU dlls. On a 64-bit system user is more likely to have the 64-bit SDK installed. This also makes it work on 32-bit system where we previously failed and tried to start the 64-bit testhost.exe

@nohwnd nohwnd marked this pull request as draft August 4, 2020 10:56
@nohwnd nohwnd marked this pull request as ready for review August 4, 2020 12:25
@ghost
Copy link

ghost commented Aug 4, 2020

Hello @nohwnd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit da7967a into microsoft:master Aug 4, 2020
nohwnd added a commit to nohwnd/test-templates that referenced this pull request Aug 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants