Use jsonSerializer2 for protocol version 3 #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanan07
reviewed
Nov 12, 2020
....TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestResultSerializationTests.cs
Outdated
Show resolved
Hide resolved
Haplois
approved these changes
Nov 13, 2020
cvpoienaru
approved these changes
Nov 13, 2020
Sanan07
reviewed
Nov 13, 2020
src/Microsoft.TestPlatform.CrossPlatEngine/EventHandlers/TestRequestHandler.cs
Show resolved
Hide resolved
fhnaseer
reviewed
Nov 16, 2020
| @@ -37,7 +37,7 @@ public class VsTestConsoleRequestSenderTests | |||
|
|
|||
| private readonly int WaitTimeout = 2000; | |||
|
|
|||
| private int protocolVersion = 3; | |||
| private int protocolVersion = 4; | |||
There was a problem hiding this comment.
const for all version numbers?,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the protocol to version 3 resulted in using serializer for v1, which sends two to three times more data. We cannot easily update how vstest.console behaves (e. g. the one shipped with net sdd 3.1.402), which will ask for protocol 3. So this PR will downgrade protocol 3 to 2. Any newer version would still be negotiable. Such as the protocol version 4 this PR introduces. Similarly protocol 3 is still using the old serializer, to keep compatibility in situations where we actually negotiate protocol 3. E.g. new console asking Test.SDK 16.7.1 for protocol version, where console would offer 4, but testhost would return 3. So 3 would be used with that specific version of SDK.
Related issue
Fix #2623