Dynamic corelib.net loading #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubch1
reviewed
Feb 19, 2021
|
|
||
| foreach(var file in files.Skip(1)) | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
|
|
There was a problem hiding this comment.
Maybe add comment why we are invoking it dynamically.
Also add try catch block inside this method or when you call MergeCodeCoverageFilesAsync. Make sure we return original attachments in case of error
jakubch1
approved these changes
Feb 19, 2021
fhnaseer
added a commit
that referenced
this pull request
Mar 8, 2021
* First working version, * Calling async method, * Cleaning code, * Reverting changes, * Fixing test, * Copy to output required libs to fix tests * Next fix Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>
fhnaseer
added a commit
that referenced
this pull request
Mar 8, 2021
* First working version, * Calling async method, * Cleaning code, * Reverting changes, * Fixing test, * Copy to output required libs to fix tests * Next fix Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>
Haplois
added a commit
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.