Add PublicAPI analyzer to all public projects

scripts/build/TestPlatform.Dependencies.props

@@ -53,6 +53,8 @@
     <SystemNetHttpVersion>4.3.4</SystemNetHttpVersion>
 
     <DependencyVersionsImported>true</DependencyVersionsImported>
+
+    <RoslynPublicApiAnalyzersVersion>3.3.4-beta1.21554.2</RoslynPublicApiAnalyzersVersion>
   </PropertyGroup>
 
   <Import Project="$(MSBuildThisFileDirectory)..\..\eng\Versions.props" />

scripts/build/TestPlatform.Settings.targets

@@ -49,6 +49,22 @@
     </AdditionalFiles>
   </ItemGroup>
 
+  <!-- Include PublicApi analyzers into all projects that are in our src directory, this can't use TestProject == true
+  because some projects in test and playground are not tests, but we don't want to analyze those for public apis, because
+  we don't ship them.
+  -->
+  <Choose>
+    <When Condition="$(MSBuildProjectFullPath.Contains('/src/')) OR $(MSBuildProjectFullPath.Contains('\src\'))">
+      <ItemGroup>
+        <!-- We normally don't build against net6.0, so the public api analyzer errors would only appear in CI pipeline. -->
+        <PackageReference Condition=" '$(DotNetBuildFromSource)' != 'true' " Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(RoslynPublicApiAnalyzersVersion)">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+	    </ItemGroup>
+    </When>
+  </Choose>
+
   <!-- Test project settings -->
   <Choose>
     <When Condition="$(TestProject) == 'true'"> 

src/AttachVS/AttachVS.csproj

@@ -1,16 +1,20 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-	<TestPlatformRoot Condition="$(TestPlatformRoot) == ''">..\..\</TestPlatformRoot>
-	<TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
+  <TestPlatformRoot Condition="$(TestPlatformRoot) == ''">..\..\</TestPlatformRoot>
+  <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
   </PropertyGroup>
   <Import Project="$(TestPlatformRoot)scripts/build/TestPlatform.Settings.targets" />
-	
+  
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFrameworks>net472</TargetFrameworks>
     <LangVersion>preview</LangVersion>
     <AssemblyName>AttachVS</AssemblyName>
   </PropertyGroup>
-
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+  </ItemGroup>
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>

src/DataCollectors/DumpMinitool.x86/DumpMinitool.x86.csproj

@@ -22,4 +22,10 @@
   <ItemGroup>
     <Compile Include="..\DumpMinitool\Program.cs" Link="Program.cs" />
   </ItemGroup>
+
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+  </ItemGroup>
 </Project>

src/DataCollectors/DumpMinitool/DumpMinitool.csproj

@@ -16,6 +16,12 @@
     <RuntimeIdentifier Condition=" '$(DotNetBuildFromSource)' != 'true' ">win7-x86</RuntimeIdentifier>
     <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects>
   </PropertyGroup>
+
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="..\DumpMinitool.x86\PublicAPI\PublicAPI.Shipped.txt" Link="PublicAPI\PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="..\DumpMinitool.x86\PublicAPI\PublicAPI.Unshipped.txt" Link="PublicAPI\PublicAPI.Unshipped.txt" />
+  </ItemGroup>
 
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>

src/DataCollectors/Microsoft.TestPlatform.Extensions.EventLogCollector/Microsoft.TestPlatform.Extensions.EventLogCollector.csproj

@@ -50,5 +50,13 @@
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
     </None>
   </ItemGroup>
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+    <!-- Framework specific API -->
+    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
+  </ItemGroup>
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>

src/DataCollectors/Microsoft.TestPlatform.Extensions.EventLogCollector/PublicAPI/PublicAPI.Shipped.txt

@@ -0,0 +1,4 @@
+Microsoft.TestPlatform.Extensions.EventLogCollector.EventLogDataCollector
+Microsoft.TestPlatform.Extensions.EventLogCollector.EventLogDataCollector.EventLogDataCollector() -> void
+override Microsoft.TestPlatform.Extensions.EventLogCollector.EventLogDataCollector.Dispose(bool disposing) -> void
+override Microsoft.TestPlatform.Extensions.EventLogCollector.EventLogDataCollector.Initialize(System.Xml.XmlElement configurationElement, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.DataCollectionEvents events, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.DataCollectionSink dataSink, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.DataCollectionLogger logger, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.DataCollectionEnvironmentContext dataCollectionEnvironmentContext) -> void

src/Microsoft.TestPlatform.AdapterUtilities/Microsoft.TestPlatform.AdapterUtilities.csproj

@@ -54,5 +54,14 @@
     -->
   </ItemGroup>
 
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+    <!-- API that is common to all frameworks except for .NET Standard 1.0 and UAP10. -->
+    <AdditionalFiles Condition=" '$(TargetFramework)' != 'netstandard1.0' AND '$(TargetFramework)' != 'uap10.0' " Include="PublicAPI\net\PublicAPI.Shipped.txt" />
+    <AdditionalFiles Condition=" '$(TargetFramework)' != 'netstandard1.0' AND '$(TargetFramework)' != 'uap10.0' " Include="PublicAPI\net\PublicAPI.Unshipped.txt" />
+  </ItemGroup>
+
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>

src/Microsoft.TestPlatform.AdapterUtilities/PublicAPI/PublicAPI.Shipped.txt

@@ -0,0 +1,27 @@
+const Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.HierarchyLabel = "Hierarchy" -> string
+const Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.HierarchyPropertyId = "TestCase.Hierarchy" -> string
+const Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.Levels.ClassIndex = 1 -> int
+const Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.Levels.NamespaceIndex = 0 -> int
+const Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.Levels.TotalLevelCount = 2 -> int
+const Microsoft.TestPlatform.AdapterUtilities.ManagedNameConstants.ManagedMethodLabel = "ManagedMethod" -> string
+const Microsoft.TestPlatform.AdapterUtilities.ManagedNameConstants.ManagedMethodPropertyId = "TestCase.ManagedMethod" -> string
+const Microsoft.TestPlatform.AdapterUtilities.ManagedNameConstants.ManagedTypeLabel = "ManagedType" -> string
+const Microsoft.TestPlatform.AdapterUtilities.ManagedNameConstants.ManagedTypePropertyId = "TestCase.ManagedType" -> string
+Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants
+Microsoft.TestPlatform.AdapterUtilities.HierarchyConstants.Levels
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameConstants
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.InvalidManagedNameException
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.InvalidManagedNameException.InvalidManagedNameException(string message) -> void
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameHelper
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameParser
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameParser.ManagedNameParser() -> void
+Microsoft.TestPlatform.AdapterUtilities.TestIdProvider
+Microsoft.TestPlatform.AdapterUtilities.TestIdProvider.AppendString(string str) -> void
+Microsoft.TestPlatform.AdapterUtilities.TestIdProvider.GetHash() -> byte[]
+Microsoft.TestPlatform.AdapterUtilities.TestIdProvider.GetId() -> System.Guid
+Microsoft.TestPlatform.AdapterUtilities.TestIdProvider.TestIdProvider() -> void
+static Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameHelper.GetManagedName(System.Reflection.MethodBase method, out string managedTypeName, out string managedMethodName) -> void
+static Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameHelper.GetManagedName(System.Reflection.MethodBase method, out string managedTypeName, out string managedMethodName, out string[] hierarchyValues) -> void
+static Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameHelper.GetMethod(System.Reflection.Assembly assembly, string managedTypeName, string managedMethodName) -> System.Reflection.MethodBase
+static Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameParser.ParseManagedMethodName(string managedMethodName, out string methodName, out int arity, out string[] parameterTypes) -> void
+static Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.ManagedNameParser.ParseManagedTypeName(string managedTypeName, out string namespaceName, out string typeName) -> void

src/Microsoft.TestPlatform.AdapterUtilities/PublicAPI/net/PublicAPI.Shipped.txt

@@ -0,0 +1 @@
+Microsoft.TestPlatform.AdapterUtilities.ManagedNameUtilities.InvalidManagedNameException.InvalidManagedNameException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) -> void

src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj

@@ -37,6 +37,11 @@
     <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkPackageVersion)" />
     <PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCorePackageVersion)" />
   </ItemGroup>
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+  </ItemGroup>
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>
 

src/Microsoft.TestPlatform.Build/PublicAPI/PublicAPI.Shipped.txt

@@ -0,0 +1,66 @@
+Microsoft.TestPlatform.Build.Tasks.VSTestForwardingApp
+Microsoft.TestPlatform.Build.Tasks.VSTestForwardingApp.Cancel() -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestForwardingApp.Execute() -> int
+Microsoft.TestPlatform.Build.Tasks.VSTestForwardingApp.VSTestForwardingApp(string vsTestExePath, System.Collections.Generic.IEnumerable<string> argsToForward) -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.LogType.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.LogType.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.ProjectFilePath.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.ProjectFilePath.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.VSTestLogsTask() -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.Cancel() -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.TestFileFullPath.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.TestFileFullPath.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlame.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlame.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrash.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrash.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrashCollectAlways.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrashCollectAlways.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrashDumpType.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameCrashDumpType.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHang.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHang.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHangDumpType.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHangDumpType.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHangTimeout.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestBlameHangTimeout.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestCLIRunSettings.get -> string[]
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestCLIRunSettings.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestCollect.get -> string[]
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestCollect.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestConsolePath.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestConsolePath.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestDiag.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestDiag.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestFramework.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestFramework.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestListTests.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestListTests.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestLogger.get -> string[]
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestLogger.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestNoLogo.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestNoLogo.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestPlatform.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestPlatform.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestResultsDirectory.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestResultsDirectory.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestSetting.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestSetting.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTask() -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTestAdapterPath.get -> string[]
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTestAdapterPath.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTestCaseFilter.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTestCaseFilter.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTraceDataCollectorDirectoryPath.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestTraceDataCollectorDirectoryPath.set -> void
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestVerbosity.get -> string
+Microsoft.TestPlatform.Build.Tasks.VSTestTask.VSTestVerbosity.set -> void
+Microsoft.TestPlatform.Build.Trace.Tracing
+Microsoft.TestPlatform.Build.Utils.ArgumentEscaper
+override Microsoft.TestPlatform.Build.Tasks.VSTestLogsTask.Execute() -> bool
+override Microsoft.TestPlatform.Build.Tasks.VSTestTask.Execute() -> bool
+static Microsoft.TestPlatform.Build.Trace.Tracing.Trace(string message) -> void
+static Microsoft.TestPlatform.Build.Trace.Tracing.traceEnabled -> bool
+static Microsoft.TestPlatform.Build.Utils.ArgumentEscaper.HandleEscapeSequenceInArgForProcessStart(string arg) -> string

src/Microsoft.TestPlatform.Client/Microsoft.TestPlatform.Client.csproj

@@ -46,5 +46,13 @@
   <PropertyGroup Label="Configuration">
     <RootNamespace>Microsoft.VisualStudio.TestPlatform.Client</RootNamespace>
   </PropertyGroup>
+  <ItemGroup>
+    <!-- API that is common to all frameworks that we build for. -->
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
+    <!-- Framework specific API -->
+    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
+  </ItemGroup>
   <Import Project="$(TestPlatformRoot)scripts\build\TestPlatform.targets" />
 </Project>