Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to loaded assembly if load file fails during the extension discovery v2 #3315

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Fallback to loaded assembly if load file fails during the extension discovery v2 #3315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05913b9
fallback to loaded assembly if load file fails
MarcoRossignoli Feb 1, 2022
126ad75
update log message
MarcoRossignoli Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Microsoft.TestPlatform.Common/Utilities/MetadataReaderHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,16 @@ private Type[] DiscoverTestExtensionTypesV2AttributeInternal(Assembly loadedAsse

#if !NETSTANDARD1_3
// We don't cache the load because this method is used by DiscoverTestExtensionTypesV2Attribute that caches the outcome Type[]
Assembly assemblyToAnalyze = Assembly.LoadFile(assemblyFilePath);
Assembly assemblyToAnalyze;
try
{
assemblyToAnalyze = Assembly.LoadFile(assemblyFilePath);
}
catch (Exception ex)
{
EqtTrace.Verbose($"MetadataReaderExtensionsHelper: Failure during assembly file load '{assemblyFilePath}', fallback to the loaded assembly.\n{FormatException(ex)}");
assemblyToAnalyze = loadedAssembly;
}
#else
Assembly assemblyToAnalyze = loadedAssembly;
#endif
Expand Down