Suppress assembly architecture, assembly conflict and restore warnings #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that we can't avoid
Evangelink
reviewed
Feb 3, 2022
| @@ -68,6 +68,8 @@ | |||
| <When Condition="$(TestProject) == 'true'"> | |||
| <PropertyGroup> | |||
| <GenerateDocumentationFile>false</GenerateDocumentationFile> | |||
| <!-- Suppress warnings about testhost being x64 (AMD64)/x86 when imported into AnyCPU (MSIL) test projects. --> | |||
| <NoWarn>$(NoWarn);MSB3270</NoWarn> | |||
There was a problem hiding this comment.
Do we need both this and the MSBuildWarningsAsMessages in each project?
There was a problem hiding this comment.
We don't suppress this warning in each project, just in some. This is blanket suppression for all TestProjects.
There was a problem hiding this comment.
Sorry I wasn't clear. I meant do we need both NoWarn and MSBuildWarningsAsMessages applied (I see that both are "suppressing" the MSB3270).
There was a problem hiding this comment.
Suggested change
| <NoWarn>$(NoWarn);MSB3270</NoWarn> | |
| <MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);MSB3270</MSBuildWarningsAsMessages> |
Do I get it correctly that you want me to do this ^^^ ?
There was a problem hiding this comment.
Or the other way around depending on which of the 2 property has wider area but yes :)
Evangelink
reviewed
Feb 3, 2022
...rm.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 3, 2022
...ataCollector.UnitTests/Microsoft.TestPlatform.Extensions.BlameDataCollector.UnitTests.csproj
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 3, 2022
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…om/nohwnd/vstest into suppress-testhost-related-warnings
Evangelink
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress assembly architecture, assembly conflict and restore warnings that we can't avoid. This is preliminary work to enabling Warnings to be just warnings for local development. And then probably warnings as errors in PR, or ideally warnings as errors in real PRs and warnings as warnings in draft PRs.