Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failfast #3327

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Fix failfast #3327

merged 3 commits into from
Feb 4, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 4, 2022

Pass the exit code directly because we no longer rely on LastExitCode for executables.

Add colors to lines that match " error" and " warning".

@@ -55,6 +55,7 @@ Param(
)

$ErrorActionPreference = 'Stop'
$ErrorView = 'Normal'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables the summary view in Pwsh that tries to summarize the error. We want to see the error in full.

@nohwnd nohwnd merged commit 590aba3 into microsoft:main Feb 4, 2022
@nohwnd nohwnd deleted the fix-failfast branch February 4, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants