Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 .NET Framework testhost #3370

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 15, 2022

Description

Add arm64 testhost for .NET Framework.

@@ -880,6 +883,18 @@ Global
{B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x64.Build.0 = Release|Any CPU
{B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x86.ActiveCfg = Release|Any CPU
{B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x86.Build.0 = Release|Any CPU
{186069FE-E1E8-4DE1-BEA4-0FF1484D22D1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we are doing the same thing for testhost and testhost.x86 but I am still surprised. Why do we compile in AnyCpu if that's a platform specific exe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly. It is probably done out of habit. We ngen these when inserting into VS, but not when inserting into dotnet sdk.

@nohwnd nohwnd enabled auto-merge (squash) February 16, 2022 09:12
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@nohwnd nohwnd disabled auto-merge February 16, 2022 11:03
@nohwnd nohwnd merged commit 5532174 into microsoft:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants