Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test adapter loading strategy #3380

Merged
merged 10 commits into from
Feb 18, 2022

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Feb 16, 2022

Description

The code here is cherry-picked from our 17.1 release.

Work left

  • Fix the bug where we fail to retrieve TestAdapterLoadingStrategy from .runsettings file.
  • Fix typos in console help text.
  • Add documentation
  • Add tests

@Haplois Haplois force-pushed the dev/haplois/test-adapter-loading-strategy branch from bdeb9d9 to b58979f Compare February 17, 2022 00:22
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

Co-authored-by: Marco Rossignoli <marco.rossignoli@gmail.com>
src/Microsoft.TestPlatform.Client/TestPlatform.cs Outdated Show resolved Hide resolved
@@ -91,15 +90,15 @@ public TestPlatform()
PopulateExtensions(discoveryCriteria.RunSettings, discoveryCriteria.Sources);

// Initialize loggers.
var loggerManager = TestEngine.GetLoggerManager(requestData);
ITestLoggerManager loggerManager = TestEngine.GetLoggerManager(requestData);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we all agree, I could change the var rules in the repo to favor explicit type when not obvious.

My opinion: I usually prefer var in VS but that's true that var in GitHub review is a bit of a pain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love var, but wgen it's not obvious it hard do discern that while reviewing. I would vote for yes.

src/Microsoft.TestPlatform.Client/TestPlatform.cs Outdated Show resolved Hide resolved
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few extra minor remarks but otherwise LGTM. Might be worth to have a 2nd approval before merging.

@Haplois
Copy link
Contributor Author

Haplois commented Feb 17, 2022

@Evangelink thanks for the review, I'll add the tests and ask for another review.

@Evangelink Evangelink merged commit 947114d into main Feb 18, 2022
@Evangelink Evangelink deleted the dev/haplois/test-adapter-loading-strategy branch February 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to change the behavior when picking up default TestAdapters
4 participants