Make Cancel Discovery faster and more reliable #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests at the start that are fast to discover and cancel only once on the first of them (#3526).
Make the delay much smaller because it is multiplied by 3 because we create that attribute 3 times (microsoft/testfx#1056). This makes the first test be reported much sooner (we wait for all attributes to be created when scanning the class / dll microsoft/testfx#1057). Then to make sure discovery is still running, add 3 tests that slow down the discovery to make sure we are still discovering while we call cancel.