Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more issues with parallel discovery and cancellation #3605

Merged
merged 19 commits into from
May 9, 2022
Merged

Fix more issues with parallel discovery and cancellation #3605

merged 19 commits into from
May 9, 2022

Commits on May 9, 2022

  1. Source with no tests is considered as fully discovered 

    Ensure source with no test is marked as fully discovered on discovery complete.
    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2192088 View commit details
    Browse the repository at this point in the history

  2. Mark all sources of a discovery as not discovered 

    Ensure that all sources of a discovery request are marked as not discovered even if some abort was to occur before all proxy managers were instantiated.
    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    3694418 View commit details
    Browse the repository at this point in the history

  3. Add some assertions to protect state

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    20c9226 View commit details
    Browse the repository at this point in the history

  4. Update printed message when abort is expected 

    Before this we were printing "The active test discovery was aborted. Reason: Test host process crashed" which could be confusing because this abort was expected and not due to some crash. After the change we will print only the 1st part of the message.
    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7e0a2ea View commit details
    Browse the repository at this point in the history

  5. Improve trace messages

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    33bb7a0 View commit details
    Browse the repository at this point in the history

  6. Fix concurrency issue causing multiple discovery complete to be raised

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    0f4ad8d View commit details
    Browse the repository at this point in the history

  7. Remove dead code

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d6c65e1 View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    83e7cf9 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Jakub Jareš <me@jakubjares.com>
    @Evangelink @nohwnd
    Evangelink and nohwnd committed May 9, 2022
    Configuration menu
    Copy the full SHA
    9d508e7 View commit details
    Browse the repository at this point in the history

  10. Improves debug assert message

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4383c54 View commit details
    Browse the repository at this point in the history

  11. Update test/Microsoft.TestPlatform.CrossPlatEngine.UnitTests/Client/P… 

    …arallel/DiscoveryDataAggregatorTests.cs

Co-authored-by: Jakub Jareš <me@jakubjares.com>
    @Evangelink @nohwnd
    Evangelink and nohwnd committed May 9, 2022
    Configuration menu
    Copy the full SHA
    e44b5f7 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review 

    Co-authored-by: Shyam N <shyamnamboodiripad@users.noreply.github.com>
    @Evangelink @shyamnamboodiripad
    Evangelink and shyamnamboodiripad committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7230c1c View commit details
    Browse the repository at this point in the history

  13. Fix Debug.Assert condition for LUT

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    07ab622 View commit details
    Browse the repository at this point in the history

  14. Log only when source status changes

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6742f31 View commit details
    Browse the repository at this point in the history

  15. Add more logs to help with debugging

    @Evangelink
    Evangelink committed May 9, 2022
    Configuration menu
    Copy the full SHA
    53081eb View commit details