Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-process vstest.console #3728

Merged
merged 28 commits into from
Jul 21, 2022
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 8, 2022

Description

Make vstest.console usable from process.

@nohwnd nohwnd changed the title Playground improvements In-process vstest.console Jun 8, 2022
TestPlatform.sln Show resolved Hide resolved
src/vstest.console/InProcessVsTestConsoleWrapper.cs Outdated Show resolved Hide resolved
src/vstest.console/InProcessVsTestConsoleWrapper.cs Outdated Show resolved Hide resolved
src/vstest.console/InProcessVsTestConsoleWrapper.cs Outdated Show resolved Hide resolved
src/vstest.console/InProcessVsTestConsoleWrapper.cs Outdated Show resolved Hide resolved
src/vstest.console/InProcessVsTestConsoleWrapper.cs Outdated Show resolved Hide resolved
@cvpoienaru cvpoienaru marked this pull request as ready for review July 20, 2022 12:26
@cvpoienaru cvpoienaru enabled auto-merge (squash) July 20, 2022 14:16
{
// Close the sender as it failed to host server.
_requestSender.Close();
throw new TransationLayerException("Error hosting communication channel.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need a resx entry here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it missing a push? I still see the string entry here.

@cvpoienaru cvpoienaru merged commit 8053633 into microsoft:main Jul 21, 2022
cvpoienaru added a commit to cvpoienaru/vstest that referenced this pull request Jul 21, 2022
cvpoienaru added a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants