Enable nullable on ObjectModel #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
force-pushed
the
enable-nullable-object-model
branch
from
82f4eb6
to
57d13e9
Compare
MarcoRossignoli
approved these changes
Jun 22, 2022
This was referenced Jul 21, 2022
alexrp
reviewed
Aug 12, 2022
| @@ -22,15 +20,15 @@ public interface ITestExecutor | |||
| /// <param name="tests">Tests to be run.</param> | |||
| /// <param name="runContext">Context to use when executing the tests.</param> | |||
| /// <param param name="frameworkHandle">Handle to the framework to record results and to do framework operations.</param> | |||
| void RunTests(IEnumerable<TestCase> tests, IRunContext runContext, IFrameworkHandle frameworkHandle); | |||
| void RunTests(IEnumerable<TestCase>? tests, IRunContext? runContext, IFrameworkHandle? frameworkHandle); | |||
There was a problem hiding this comment.
@Evangelink I just updated to v17.3.0 of Microsoft.TestPlatform.ObjectModel and got nullable errors due to the annotations on these two RunTests methods.
Are they actually correct? I've looked at implementations both in this repo and the wild and no one seems to expect any of these parameters to ever be null.
There was a problem hiding this comment.
Hi @alexrp, thanks for raising this. I am just coming back from vacation and I will look into it this week.
There was a problem hiding this comment.
Looking at mstest, xunit and nunit, it seems that tests cannot be null but runContext can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to AB#1549371