Improve how to retrieve process ID #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,14 @@ internal class ArtifactProcessingManager : IArtifactProcessingManager | |||
| { | |||
| _testSessionCorrelationId = testSessionCorrelationId; | |||
| _processArtifactFolder = Path.Combine(_fileHelper.GetTempPath(), _testSessionCorrelationId); | |||
| _testSessionProcessArtifactFolder = Path.Combine(_processArtifactFolder, $"{Process.GetCurrentProcess().Id}_{Guid.NewGuid()}"); | |||
| #if NET5_0_OR_GREATER | |||
| var pid = Environment.ProcessId; | |||
There was a problem hiding this comment.
is it cached by design?
There was a problem hiding this comment.
System.Diagnostics.Process.GetCurrentProcess().Id is expensive:
It allocates a Process instance, usually just to get the Id.
The Process instance needs to be disposed, which has a performance impact.
It's easy to forget to call Dispose() on the Process instance.
If nothing else besides Id uses the Process instance, then the linked size grows unnecessarily by increasing the graph of types referenced.
It is somewhat difficult to discover or find this API.
System.Environment.ProcessId avoids all the above.
MarcoRossignoli
approved these changes
Jun 22, 2022
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1837