Bump to 17.4.0 #3831
Merged
Bump to 17.4.0 #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
@Haplois Can we share the version somehow between the 2 parts? Or is it possible to create a script that validates the versions produced so we avoid doing a partial bump as we did?
Evangelink
reviewed
Jun 30, 2022
| @@ -11,7 +11,7 @@ | |||
| <!-- this version also needs to be "statically" readable because the test fixture will inspect this file for the version | |||
| and because during the test `dotnet test` will run and re-build some of the test projects and at that time the version | |||
| from a build parameter would not be available, so I am writing this version from the build.ps1 script to keep it in sync --> | |||
| <NETTestSdkVersion>17.4.0-dev</NETTestSdkVersion> | |||
| <NETTestSdkVersion>17.3.0-dev</NETTestSdkVersion> | |||
There was a problem hiding this comment.
Might be worth to add a comment why this can't be latest version.
There was a problem hiding this comment.
Isn't clear from the comment :) ?
I will update our build script to build and update the version accordingly like we do in TestFx when we provide external versions. |
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to 17.4.0
completes #3818