Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parallelize default platform tests #3849

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jul 13, 2022

Description

Do not parallelize tests for default platform.

@nohwnd nohwnd requested a review from Evangelink July 13, 2022 13:01
@nohwnd
Copy link
Member Author

nohwnd commented Jul 13, 2022

@MarcoRossignoli the static platform check strikes again. Probably no time to do it the better way we discussed in this sprint. (By adding a "userSet" field on each node in runsettings.

@@ -2578,9 +2579,14 @@ private void DiscoverTestsIfThrowsExceptionShouldThrowOut(Exception exception)
[DataRow("x86")]
[DataRow("x64")]
[DataRow("arm64")]
// Don't parallelize because we can run into conflict with GetDefaultArchitecture -> RunSettingsHelper.Instance.IsDefaultTargetArchitecture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rework the static so that the test can be run in parallel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if we do the work to populate the attribute on the actual runsettings text and read it from there.

@MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli the static platform check strikes again. Probably no time to do it the better way we discussed in this sprint. (By adding a "userSet" field on each node in runsettings.

Yeah...it's on backlog.

…anagerTests.cs

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@nohwnd nohwnd enabled auto-merge (squash) July 19, 2022 08:33
@nohwnd nohwnd merged commit e85a600 into microsoft:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants