Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rel/17.3] Do not match .NET Standard to Dotnet testhost runner #3958

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Aug 22, 2022

Description

.NET Standard is not executable by .NET runner, but in multi TFM we try to execute it which does not work. Instead we should correctly report that there is no runtime provider for it.

Improve error message when testhost crashes to mention the sources that it tried to run.

Related issue

Related #3939

Backport of #3949

@nohwnd nohwnd changed the base branch from main to rel/17.3 August 22, 2022 14:42
@nohwnd nohwnd force-pushed the don-t-match-netstandard-17-3 branch from 07b3b95 to fb77989 Compare August 22, 2022 14:44
@nohwnd nohwnd changed the title Updated version tag to release. [rel/17.3] Do not match .NET Standard to Dotnet testhost runner Aug 22, 2022
@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Aug 23, 2022

what's the state here? Would be good merge this one we're having feedbacks...

@Evangelink
Copy link
Member

@nohwnd Shall we plan a bug fix release now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants