Enabled Diag logging for DataCollector #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshjain2, |
singhsarab
reviewed
Mar 16, 2017
| /// <summary> | ||
| /// Helper class for processing argumets passed to a process. | ||
| /// </summary> | ||
| public class CommandLineArgumentsHelper |
There was a problem hiding this comment.
Does this need to be public?
Nit: typo in docs
singhsarab
reviewed
Mar 16, 2017
| [TestClass] | ||
| public class CommandLineArgumentsHelperTests | ||
| { | ||
| [TestMethod] |
There was a problem hiding this comment.
Add case for
I) null args
ii) --hello --world
singhsarab
reviewed
Mar 16, 2017
| @@ -216,7 +219,20 @@ private IList<string> GetCommandLineArguments(int portNumber) | |||
| commandlineArguments.Add(PortOption); | |||
| commandlineArguments.Add(portNumber.ToString()); | |||
|
|
|||
| if (!string.IsNullOrEmpty(EqtTrace.LogFile)) | |||
singhsarab
reviewed
Mar 16, 2017
|
|
||
| requestHandler.InitializeCommunication(port); | ||
|
|
||
| // Can only do this after InitializeCommunication because datacollector cannot "Send Log" unless communications are initialized | ||
| if (!string.IsNullOrEmpty(EqtTrace.LogFile)) |
There was a problem hiding this comment.
Check for acceptance test for diag.
There was a problem hiding this comment.
implemented in acceptance tests for data collectors.
singhsarab
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled Diag logging for DataCollector.
Related to : #309