Create new RuntimeProvider to be associated with each ProxyOperationManager #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mayankbansal018, |
codito
reviewed
Mar 23, 2017
| @@ -146,8 +146,6 @@ public virtual void Close() | |||
| finally | |||
| { | |||
| this.initialized = false; | |||
| this.testHostManager.HostExited -= this.TestHostManagerHostExited; | |||
codito
approved these changes
Mar 23, 2017
singhsarab
reviewed
Mar 23, 2017
| @@ -126,14 +126,17 @@ public HostProviderEventArgs(string message) | |||
| this.ErrroCode = 0; | |||
| } | |||
|
|
|||
| public HostProviderEventArgs(string message, int errorCode) | |||
| public HostProviderEventArgs(string message, int errorCode, int processId) | |||
There was a problem hiding this comment.
Nit:
Why don't we have separate cs file for these ?
Please add xml comments for anything that is public.
singhsarab
reviewed
Mar 23, 2017
| var isDataCollectorEnabled = XmlRunSettingsUtilities.IsDataCollectionEnabled(testRunCriteria.TestRunSettings); | ||
|
|
||
| // SetupChannel ProxyExecutionManager with data collection if data collectors are specififed in run settings. | ||
| Func<IProxyExecutionManager> proxyExecutionManagerCreator = |
There was a problem hiding this comment.
Don't we need tests for these changes ?
There was a problem hiding this comment.
yes, we do, I was thinking to put them in next PR, as to unblock the CI flow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RuntimeProvider manages individual testruntime & also has state w.r.t a runtime's errorstream, & raises events w.r.t that runtime. It is better to associate a new runtimeprovider with each ProxyOperationManager(in parallel scenario)