Enables experimental support for raw-dylib #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennykerr Can you try using the v2 feature resolver (which will be the default feature resolver in Rust 2021) to see if you can get the tests working? |
|
@rylev I gave it a try - adding |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
raw-dyliblinking support that @ricobbe has been working on has made it into nightly builds. This update conditionally takes advantage ofraw-dylibfor Win32 functions when theraw_dylibfeature is selected. Unfortunately, a test could not be added because cargo ends up sharing the feature-enabledwindowscrate with all tests and I'm not yet ready to turn it on everywhere. Still, this lets us start experimenting with the feature in other crates. Once this is published I'll update some of the samples to use this feature.Fixes #463