DOT NOT MERGE - SMOKE TEST

[andrueastman]

This pull request was automatically created by Azure Pipelines. Important Check for unexpected deletions or changes in this PR.

Microsoft Reviewers: Open in CodeFlow

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoftgraph/msgraph-sdk-dotnet/pull/2009&drop=dogfoodAlpha

[baywet]

@andrueastman here is what still looks odd at this point:

• src/Microsoft.Graph/Generated/Models/IdentityGovernance/ValueTypeObject.cs EnumObject and StringObject members are now Enum and String, which is technically correct but a breaking change
• that's it! everything else looks good.

Could you quickly whip up a PR for kiota to address that last remaining regression so we can release kiota 1.4.0 please?

[andrueastman]

@baywet
As this is a relatively new type in the code introduced about a week ago via #1993, I'd argue we label this as a fix and go ahead with the correct member names and have it clearly labeled in the changelog.
As these members should never really have ended up with the Object suffix, microsoft/kiota#2874 together with making the CodeEnumOption ended up serendipitously fixing a bug were enum options would be replaced if and only if the name of the Enum itself was replaced. This is because, the ReplaceReservedModelTypes would pass a different set of exceptions types and thus the nested enum option would be processed simply because the parent was being renamed(which is no longer the case as these are processed independently now).

[baywet]

@andrueastman thanks for providing the context here. Yes let's label that a fix and move on so we don't end up carrying an odd compatibility patch forever. Thanks. Closing.