Add support for missing Extended DNS Error Codes (EDE) #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended DNS Error (EDE) codes were missing for code points 25-30. These are documented in: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#extended-dns-error-codes
janik-cloudflare
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended DNS Error (EDE) codes were missing for code points 25-30. These are documented in:
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#extended-dns-error-codes
I was going to add support for EDE code 30 and noticed that also EDE codes 25-29 was missing so I added those as well
Thanks for you pull request, do note the following:
If your PR introduces backward incompatible changes it will very likely not be merged.
We support the last two major Go versions, if your PR uses features from a too new Go version, it
will not be merged.