Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile to use newer kubebuilder when generating manifests #1365

Merged
merged 1 commit into from
May 20, 2024
Merged

Update Makefile to use newer kubebuilder when generating manifests #1365

merged 1 commit into from
May 20, 2024

Conversation

awels
Copy link
Contributor

@awels awels commented Jan 9, 2024 •
edited
Loading

Updated Makefile arguments to match newer kubebuilder requirements.

@awels
Update Makefile to use newer kubebuilder when generating manifests
54c12ef 
Signed-off-by: Alexander Wels <awels@redhat.com>
@github-actions github-actions bot added the update-operator Requires updates to mig-operator CRDs / RBAC label Jan 9, 2024
pranavgaikwad
pranavgaikwad reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. I am not sure how that affects operator / release things. @jmontleon Let me know what you think about this

jmontleon
jmontleon approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmontleon
Copy link
Contributor

They'll need to be copied to
https://github.com/migtools/mig-operator/tree/master/deploy/olm-catalog/bundle/manifests

It looks like the leading empty lines got deleted? This is good; they break the operator if they remain...

@awels
Copy link
Contributor Author

awels commented May 16, 2024

Hmm it never notified me about these comments, I will take care of copying the stuff to the olm bundle.

awels added a commit to awels/mig-operator that referenced this pull request May 17, 2024
@awels
Update CRD manifests for OLM
a253854 
This commit matches:
migtools/mig-controller#1365

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels awels mentioned this pull request May 17, 2024
Merged
@awels
Copy link
Contributor Author

awels commented May 17, 2024

They'll need to be copied to https://github.com/migtools/mig-operator/tree/master/deploy/olm-catalog/bundle/manifests

It looks like the leading empty lines got deleted? This is good; they break the operator if they remain...

Matching PR to update OLM bundle migtools/mig-operator#903

rayfordj pushed a commit to migtools/mig-operator that referenced this pull request May 20, 2024
@awels
Update CRD manifests for OLM (#903)
3e3d59a 
This commit matches:
migtools/mig-controller#1365

Signed-off-by: Alexander Wels <awels@redhat.com>
rayfordj
rayfordj approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rayfordj rayfordj merged commit a7379f7 into migtools:master May 20, 2024
1 check passed
dymurray pushed a commit to migtools/mig-operator that referenced this pull request Jul 17, 2024
@awels @dymurray
Update CRD manifests for OLM (#903)
48232fc 
This commit matches:
migtools/mig-controller#1365

Signed-off-by: Alexander Wels <awels@redhat.com>
(cherry picked from commit 3e3d59a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad left review comments

@jmontleon jmontleon jmontleon approved these changes

@rayfordj rayfordj rayfordj approved these changes

Assignees
No one assigned
Labels
update-operator Requires updates to mig-operator CRDs / RBAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awels @jmontleon @rayfordj @pranavgaikwad