-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update status design with NAR and delete #70
base: master
Are you sure you want to change the base?
fix: Update status design with NAR and delete #70
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -738,6 +738,150 @@ spec: | |||
file in object storage. | |||
type: integer | |||
type: object | |||
veleroObject: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading design I though about this: creating a struct that contains all velero things
- name
- namespace
- status
called veleroObject but it could be veleroBackup and veleroRestore for NAB and NAR respectively
What you think?
if you like, will delete veleroBackupName, veleroBackupNamespace and veleroBackupStatus from NonAdminBackupStatus; otherwise, I delete the added code
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Why the changes were made
Follow up of #23 to:
How to test the changes made
Read design and see if it is clear and the code follows it.