Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws, engine.io and engine.io-client in /examples/client/javascript #364

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2024

Bumps ws to 8.17.1 and updates ancestor dependencies ws, engine.io and engine.io-client. These dependencies need to be updated together.

Updates ws from 7.2.5 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates engine.io from 6.4.2 to 6.6.0

Release notes

Sourced from engine.io's releases.

6.6.0

Bug Fixes

  • fix websocket and webtransport send callbacks (#699) (fc21c4a)
  • properly call the send callback during upgrade (362bc78)
  • types: make socket.request writable (#697) (0efa04b)

Performance Improvements

  • do not reset the hearbeat timer on each packet (5359bae)
  • websocket: use bound callbacks (9a68c8c)

Credits

Huge thanks to Jonathan Perret for their contributions!

Links

6.5.5

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

Bug Fixes

Links

6.5.4

This release contains some minor changes which should improve the memory usage of the server, notably this.

Links

... (truncated)

Changelog

Sourced from engine.io's changelog.

6.6.0 (2024-06-21)

Bug Fixes

  • fix websocket and webtransport send callbacks (#699) (fc21c4a)
  • properly call the send callback during upgrade (362bc78)
  • types: make socket.request writable (#697) (0efa04b)

Performance Improvements

  • do not reset the hearbeat timer on each packet (5359bae)
  • websocket: use bound callbacks (9a68c8c)

Dependencies

6.5.5 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

Bug Fixes

Dependencies

3.6.2 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

Dependencies

... (truncated)

Commits
  • 791aa58 chore(release): 6.6.0
  • 6d8a0be refactor: move the req attribute to the polling class
  • c310b7b refactor: improve types
  • 362bc78 fix: properly call the send callback during upgrade
  • afd2934 chore(dev-deps): bump ws and engine.io-client in /examples/memory-usage (#703)
  • 56c4664 chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#701)
  • 6b9e3e4 refactor: improve types
  • f521cba refactor: simplify the heartbeat code
  • 5359bae perf: do not reset the hearbeat timer on each packet
  • d3f45dc docs(changelog): add release notes for versions 3.6.2 and 6.5.5
  • Additional commits viewable in compare view

Updates engine.io-client from 4.0.4 to 4.1.4

Release notes

Sourced from engine.io-client's releases.

4.1.4

This release only contains a bump of xmlhttprequest-ssl, in order to fix the following vulnerability: https://www.npmjs.com/advisories/1665.

Please note that engine.io-client was not directly impacted by this vulnerability, since we are always using async: true.

Links

4.1.3

Bug Fixes

  • ignore packets when the transport is silently closed (46e6de0)

Links

4.1.2

Bug Fixes

  • silently close the transport in the beforeunload hook (ed48b5d)

Links

4.1.1

Bug Fixes

  • remove polyfill for process in the bundle (c95fdea)

Links

4.1.0

Features

Links

... (truncated)

Changelog

Sourced from engine.io-client's changelog.

4.1.4 (2021-05-05)

This release only contains a bump of xmlhttprequest-ssl, in order to fix the following vulnerability: https://www.npmjs.com/advisories/1665.

Please note that engine.io-client was not directly impacted by this vulnerability, since we are always using async: true.

4.1.3 (2021-03-31)

Bug Fixes

  • ignore packets when the transport is silently closed (46e6de0)

4.1.2 (2021-02-25)

Bug Fixes

  • silently close the transport in the beforeunload hook (ed48b5d)

4.1.1 (2021-02-02)

Bug Fixes

  • remove polyfill for process in the bundle (c95fdea)

4.1.0 (2021-01-14)

Features

4.0.6 (2021-01-04)

3.5.0 (2020-12-30)

Bug Fixes

  • check the type of the initial packet (8750356)

... (truncated)

Commits
  • c03e877 chore(release): 4.1.4
  • de1456d chore: bump xmlhttprequest-ssl version
  • f6287f9 chore(release): 4.1.3
  • 46e6de0 fix: ignore packets when the transport is silently closed
  • 6f7c89d chore(release): 4.1.2
  • ed48b5d fix: silently close the transport in the beforeunload hook
  • 76338d7 refactor: use globalObject "this" in webpack configuration
  • ee0a35d chore(release): 4.1.1
  • e551fc0 chore: point towards the master branch for the CI badge
  • c95fdea fix: remove polyfill for process in the bundle
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/engine.io) and [engine.io-client](https://github.com/socketio/engine.io-client). These dependencies need to be updated together.


Updates `ws` from 7.2.5 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.2.5...8.17.1)

Updates `engine.io` from 6.4.2 to 6.6.0
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/6.6.0/CHANGELOG.md)
- [Commits](socketio/engine.io@6.4.2...6.6.0)

Updates `engine.io-client` from 4.0.4 to 4.1.4
- [Release notes](https://github.com/socketio/engine.io-client/releases)
- [Changelog](https://github.com/socketio/engine.io-client/blob/4.1.4/CHANGELOG.md)
- [Commits](socketio/engine.io-client@4.0.4...4.1.4)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: engine.io
  dependency-type: direct:production
- dependency-name: engine.io-client
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 9, 2024
@miguelgrinberg miguelgrinberg merged commit 958e74d into main Aug 10, 2024
15 of 16 checks passed
@miguelgrinberg miguelgrinberg deleted the dependabot/npm_and_yarn/examples/client/javascript/multi-b7c3500421 branch August 10, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant