Fix #5 and add tests for touch functionality #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2015
| }, | ||
|
|
||
| handleDragStart: function (e) { | ||
| handleMouseUp: function(e) { | ||
| return this.handleDragEnd(e, 'mouse'); |
There was a problem hiding this comment.
Would it make sense to add e.preventDefault() here too?
http://www.html5rocks.com/en/mobile/touchandmouse/
There was a problem hiding this comment.
Yes, absolutely, just ran into that myself. (Though in that case the preventDefault line should probably just move to handleDrag)
- onMouseDown, onMouseUp, onTouchStart, onTouchEnd props now supported. - The above user event handlers can now call preventDefault() and cleanly override drag actions. - Added tests of above functionality. - In the internal handlers, preventDefault() is called if and only if a drag operation is started. This prevents scrolling / text selection. - Modified the example to only hide user selection on the <strong/> drag handles.
mikepb
added a commit
that referenced
this pull request
Apr 21, 2015
Fix #5 and add tests for touch functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have:
rootandbodyElementin favor of always setting and clearing events onthis.getDOMNode().ownerDocument.body.isTouchDeviceand the either/or relationship between touch and mouse events in favor of tracking the source device on a per-drag basis. This tracking relies on having separate handlers for touch and mouse events; For the record, my earlier approach of just inspectingevent.typein the shared handlers did not pan out, becauseTestUtils.Simulatedoesn't seem to set that property.dragEventForin favor ofdragEventsFor.mouseanddragEventsFor.touch.state.draggingslightly - its value is now always one offalse,'touch'and'mouse'. This is mainly so that a straymouseupdoesn't interfere with an ongoing touch-based drag operation, and vice versa.