Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #17 #18

Merged
merged 12 commits into from
May 27, 2020
Merged

fix #17 #18

merged 12 commits into from
May 27, 2020

Conversation

zachcheung
Copy link
Contributor

@zachcheung zachcheung commented May 26, 2020 •
edited
Loading

  • remove -encrypt, -decrypt, -file flags, detect automatically
  • use .enc suffix instead of long .encrypted
  • don't panic
  • add -noclipboard option

mimoo
mimoo approved these changes May 26, 2020
View reviewed changes
Copy link
Owner

@mimoo mimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! These are some good usability improvements :)

Just left two comments about the approach that I disagree with, feel free to ignore or address and merge.

README.md Outdated Show resolved Hide resolved
eureka.go Outdated Show resolved Hide resolved
@mimoo mimoo merged commit 01755be into mimoo:master May 27, 2020
@mimoo
Copy link
Owner

mimoo commented May 27, 2020

not sure if you could merge yourself? Thanks again!

@zachcheung
Copy link
Contributor Author

not sure if you could merge yourself? Thanks again!

didn't pay attention about it. not big deal~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimoo mimoo mimoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachcheung @mimoo