Override all other regions if region is set #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
approved these changes
Jan 31, 2018
We cannot add a mint test because Minio server configuration or the choice of remote endpoint is not governed by mint. |
ebozduman
requested changes
Jan 31, 2018
| @@ -296,6 +296,9 @@ def list_buckets(self): | |||
|
|
|||
| # default for all requests. | |||
| region = 'us-east-1' | |||
| # region is set then use the region. | |||
There was a problem hiding this comment.
Since we call the same code block twice, we can make it a simple method.
There was a problem hiding this comment.
There is no reason to make this a method @ebozduman - it will confuse with _get_bucket_location() - i will prefer to keep it as is.
ebozduman
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623