Support for specifying custom presign request date #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheungpat
force-pushed
the
specify-request-date
branch
from
1977e4d
to
05df7a9
Compare
harshavardhana
requested changes
Apr 19, 2018
|
oh thanks for reminding! sorry it is my first time contributing here : ) |
|
No problem this is a nice change.. thanks for the PR |
|
@cheungpat thanks for this PR. Are you going to update docs/API.md as suggested by @harshavardhana ? |
|
@vadmeste Oh yes. Thanks for reminding! |
This allows the request date used for presigning the request to be configurable.
cheungpat
force-pushed
the
specify-request-date
branch
from
05df7a9
to
2306f53
Compare
|
Updated and rebased. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the request date used for presigning the request to be
configurable.
I want to make the request date configurable because I want to specify a custom
request date that is not datetime.utcnow(). For example, I want to make the
presign link to stay unchanged for a certain time period, which makes browser
caching easier.
I understand that this might not be what you guys want but I am going to try
my luck anyway :)
PS:
minio-jshas support for custom request date too, but that parameter is not exposed in exported function.