support aliyun OSS api #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -325,8 +325,9 @@ def is_virtual_host(endpoint_url, bucket_name): | |||
| # such buckets. | |||
| if 'https' in parsed_url.scheme and '.' in bucket_name: | |||
| return False | |||
| if 's3.amazonaws.com' in parsed_url.netloc: | |||
| return True | |||
| for host in ['s3.amazonaws.com', 'aliyuncs.com']: | |||
There was a problem hiding this comment.
@laixintao if things are working, I have no issues about this change. Can you confirm?
balamurugana
approved these changes
Apr 23, 2018
|
Thanks! |
harshavardhana
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I see you set two url schemes here:
minio-py/minio/helpers.py
Line 240 in 3b6e49c
But from
is_virtual_hostonly in amazon s3 returns True. I think the first url scheme is the most common one. And Aliyun OSS only support the first url scheme.Hope this can be merged ASAP.