Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-objects-v2: Add start_after parameter #744

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

vadmeste
Copy link
Member

When listing a bucket or a prefix which contains a lot of files,
it is not possible to pause/resume listing using list-objects-v2
API, adding start_after will help the developer listing from a
starting point without having to list everything again from the
beginning.

Fix #718

@vadmeste
Copy link
Member Author

vadmeste commented Mar 25, 2019

This is a breaking change!

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests. otherwise LGTM.

@vadmeste vadmeste force-pushed the add-start-after branch 3 times, most recently from b55d8d3 to e5f94aa Compare July 9, 2019 12:01
When listing a bucket or a prefix which contains a lot of files,
it is not possible to pause/resume listing using list-objects-v2
API, adding start_after will help the developer listing from a
starting point without having to list everything again from the
beginning.
@vadmeste
Copy link
Member Author

vadmeste commented Jul 9, 2019

This not an API breaking anymore:

Old API:
def list_objects_v2(self, bucket_name, prefix='', recursive=False)
New API:
def list_objects_v2(self, bucket_name, prefix='', recursive=False, start_after='')

@vadmeste
Copy link
Member Author

vadmeste commented Aug 5, 2019

ping @balamurugana @harshavardhana

@harshavardhana harshavardhana merged commit 5e2c7c9 into minio:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter to ListObjectsV2 to make the iteration interruptible
3 participants