Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds debug code to diagnose Issue#755 #758

Merged

Conversation

ebozduman
Copy link
Collaborator

@ebozduman ebozduman commented Apr 30, 2019

This is not a fix but debug code to add the following information to the log_output list to help diagnose the sporadic problem, explained in Issue #755.

log_output.args['presigned_get_object_url'] = presigned_get_object_url
log_output.args['response.status'] = response.status
log_output.args['response.reason'] = response.reason
log_output.args['response.headers'] = json.dumps(response.headers.__dict__)
log_output.args['response._body'] = response._body.decode('utf-8')

The suspicion is that the client and server times are not in sync and hence we sometimes see the problem when the expiration time is either comes earlier or later than expected.

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit e8bd0e7 into minio:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants