Better error msg if metadata contains a non us-ascii character #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vadmeste, can you rebase? |
vadmeste
force-pushed
the
error
branch
3 times, most recently
from
a5f3a1b
to
0a019ea
Compare
Done |
Pass 'é' or other non us-ascii character as a metadata value shows a signature mismatch error. The reason is that S3 server ignores those characters in headers since only US-ASCII characters are supported in HTTP headers. This commit shows an exception so users can understand better what's going on.
tjd2002
added a commit
to regro-cf-autotick-bot/minio-feedstock
that referenced
this pull request
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass 'é' or other non us-ascii character as a metadata value shows
a signature mismatch error. The reason is that S3 server ignores
those characters in headers since only US-ASCII characters are
supported in HTTP headers.
This commit shows an exception so users can understand better
what's going on.
Fixes #764