Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: More fixes for better support of Github CI #812

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Oct 22, 2019

  1. Explicity create and pass temporary directories in tests

  2. Download Minio binary for both Linux & Windows and avoid
    testing directly against Play server

@harshavardhana
Copy link
Member

Looks like functional tests hang and GitHub cancels the CI

{"function": "stat_object(bucket_name, object_name, sse)", "status": "PASS", "duration": 81673, "args": {"object_name": "2bdc7324-fdd7-45a9-b10c-cfe5d56fb30a", "length": 11534336, "bucket_name": "minio-py-test-0d54bb00-0e07-478e-b49d-47a6170caf70", "content_type": "application/octet-stream", "data": "LimitedRandomReader(MB_11)", "metadata": {"X-Amz-Meta-Testing": "value"}}, "name": "minio-py:test_stat_object_with_SSE-C"}
##[error]The operation was canceled.

@vadmeste
Copy link
Member Author

Looks like functional tests hang and GitHub cancels the CI

It looks like Github cancels when there is one failed job, that's why it has two netural checks

@vadmeste
Copy link
Member Author

jobs.<job_id>.strategy.fail-fast
When set to true, GitHub cancels all in-progress jobs if any matrix job fails. Default: true

https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions

@vadmeste vadmeste force-pushed the test-pr branch 8 times, most recently from e4f68b2 to 7e3494e Compare October 23, 2019 15:39
@vadmeste vadmeste changed the title [DO NOT MERGE] Test PR [DO NOT MERGE] Fix test_fget_object so Github CI will succeed Oct 23, 2019
@vadmeste
Copy link
Member Author

vadmeste commented Oct 23, 2019

I made some changes and some advancements in Github CI but still struggling with connection reset error..

@vadmeste vadmeste force-pushed the test-pr branch 2 times, most recently from 48f6330 to 7e7f860 Compare October 23, 2019 16:37
@harshavardhana
Copy link
Member

I think you should download MinIO locally and run it like minio-go

https://github.com/minio/minio-go/blob/master/.travis.yml#L19

@vadmeste
Copy link
Member Author

I think you should download MinIO locally and run it like minio-go

https://github.com/minio/minio-go/blob/master/.travis.yml#L19

yes, good idea

@vadmeste vadmeste force-pushed the test-pr branch 13 times, most recently from 602babd to c7fb794 Compare October 24, 2019 15:36
@vadmeste vadmeste force-pushed the test-pr branch 14 times, most recently from 1376177 to 00e7735 Compare October 24, 2019 19:32
@vadmeste vadmeste changed the title [DO NOT MERGE] Fix test_fget_object so Github CI will succeed tests: More fixes for better support of Github CI Oct 24, 2019
@vadmeste
Copy link
Member Author

This is finally ready to review & merge.

.github/workflows/pythonpackage-windows.yml Outdated Show resolved Hide resolved
.github/workflows/pythonpackage-linux.yml Outdated Show resolved Hide resolved
.github/workflows/pythonpackage-linux.yml Outdated Show resolved Hide resolved
.github/workflows/pythonpackage-linux.yml Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

why generate @vadmeste commit to the minio-py since we have to use a static 127.0.0.1 IP anyways

@harshavardhana
Copy link
Member

NOTE: on windows you need it to be 127.0.0.1 not localhost @vadmeste so cert should be IP SANs

@vadmeste vadmeste force-pushed the test-pr branch 4 times, most recently from 85cb81c to da87b74 Compare October 24, 2019 20:09
1. Explicity create and pass temporary directories in tests

2. Download Minio binary for both Linux & Windows and avoid
   testing directly against Play server
@vadmeste
Copy link
Member Author

NOTE: on windows you need it to be 127.0.0.1 not localhost @vadmeste so cert should be IP SANs

It looks like it works fine with localhost

@kannappanr kannappanr merged commit c9ead63 into minio:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants