LEP-102 remove benefits as a possible 'other_income' #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripan
added
Approved
and removed
Ready for Review
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
c082efa
to
225f173
Compare
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
225f173
to
f3a6c58
Compare
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
f3a6c58
to
b0627f5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
b0627f5
to
727f655
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
727f655
to
a8b9d99
Compare
starswan
force-pushed
the
lep-102-other-income-categories
branch
from
a8b9d99
to
e83e075
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dsdmoj.atlassian.net/browse/LEP-102
'benefits' appears to be a valid 'other income' source but it is ignored. This appears to be an implementation quirk/oversight - this removes it as a possibility to prevent future confusion