SAA-354: Package frontend assets #113
Conversation
gulpfile.js
Outdated
| const gulp = require('gulp') | ||
| const concat = require('gulp-concat') | ||
| const minify = require('gulp-minify') | ||
| const umd = require('gulp-umd') | ||
| const merge = require('merge-stream') | ||
| const sass = require('gulp-sass')(require('sass')) |
There was a problem hiding this comment.
Not strongly opposed to the use of gulp, but in case you weren't aware GDS have decided to move away from gulp for their frontend builds, alphagov/govuk-frontend#2717
Have other options been considered here? Gulp hasn't been updated since 2019 and has fallen out of popularity in recent years.
There was a problem hiding this comment.
Looking at using grunt instead
There was a problem hiding this comment.
Replaced with Grunt
gulpfile.js
Outdated
| 'node_modules/jquery/dist/jquery.js', | ||
| 'node_modules/jquery-ui-dist/jquery-ui.js', |
There was a problem hiding this comment.
It looks like everywhere JQuery is used it can be replaced with vanilla JS?
The only exception seems to be the datepicker, however that's to be removed and seems to have accessible issues? I believe the datepicker is also the only place JQuery UI is being used?
Is JQuery / JQuery UI needed?
There was a problem hiding this comment.
Yea also thinking to remove it
gulpfile.js
Outdated
| exports: function () { | ||
| return 'ActivitiesFrontend' | ||
| }, | ||
| namespace: function () { | ||
| return 'ActivitiesFrontend' | ||
| }, |
There was a problem hiding this comment.
| exports: function () { | |
| return 'ActivitiesFrontend' | |
| }, | |
| namespace: function () { | |
| return 'ActivitiesFrontend' | |
| }, | |
| exports: () => 'ActivitiesFrontend', | |
| namespace: () => 'ActivitiesFrontend', |
smcveigh941
force-pushed
the
dev/SAA-354-modularise-frontend-assets
branch
2 times, most recently
from
beb8830
to
12e79d3
Compare
| @@ -0,0 +1,22 @@ | |||
| //TODO: These should be removed eventually | |||
There was a problem hiding this comment.
Why are we keeping these if they are all commented out anyway?
There was a problem hiding this comment.
They are part of the spike so will be removed, but also did not want to spend time fixing up the JS to be compatible with this new format so just commented out ... (I am unsure if we need to keep it right now for reference, but pretty sure we wont be doing Jquery driven pages)
No description provided.