Upgrading dependencies #66
Conversation
| @@ -7,7 +7,7 @@ | |||
| "scripts": { | |||
| "prepare": "husky install", | |||
| "copy-views": "cp -R server/views dist/server/", | |||
| "compile-sass": "sass --no-source-map --load-path=node_modules/govuk-frontend --load-path=node_modules/@ministryofjustice/frontend ./assets/sass/application.sass:./assets/stylesheets/application.css ./assets/sass/application-ie8.sass:./assets/stylesheets/application-ie8.css --style compressed", | |||
| "compile-sass": "sass --quiet-deps --no-source-map --load-path=node_modules/govuk-frontend --load-path=node_modules/@ministryofjustice/frontend --load-path=. ./assets/sass/application.sass:./assets/stylesheets/application.css ./assets/sass/application-ie8.sass:./assets/stylesheets/application-ie8.css --style compressed", | |||
There was a problem hiding this comment.
reduce logging on errors related to this issue
Also need to add new load path for . as govuk frontend now explicitly reference govuk node modules as a dependency related to this: ministryofjustice/moj-frontend#147
There was a problem hiding this comment.
Do we need the second one? Or do we only import bits of govuk? ...and a separate issue, what point are we ditching IE8 support? I don't believe it's in our supported browsers.
There was a problem hiding this comment.
We need all 3 - or we have to start referring to things with full paths.
The new load path is used only to bodge around the change in the moj-frontend and how they refer to assets from the gov uk frontend library.
I think we still have users in probation who use IE8, we did the last time I checked..
There was a problem hiding this comment.
Thanks for the explanation @andrewrlee 👍
| const router = express.Router() | ||
| router.use( | ||
| session({ | ||
| store: new RedisStore({ client }), | ||
| store: new RedisStore({ client: client as unknown as Client }), |
There was a problem hiding this comment.
bit gnarly - waiting on connect-redis to update to new version of redis client:
tj/connect-redis#337
No description provided.