Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second stage of new account changes for corporate-information-system #7478

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jul 10, 2024

A reference to the issue / Description of it

#7415

How does this PR fix the problem?

Completes changes for new corporate-information-system account

How has this been tested?

Followed runbook steps

Deployment Plan / Instructions

Deploy through CI

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner July 10, 2024 15:32
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments-networks/*.json files will affect the networking of MP AWS accounts, in particular which VPC/Subnet is being shared in to which environment. For more guidance consult the documentation.

@github-actions github-actions bot added onboarding Tasks to onboard teams testing labels Jul 10, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@dms1981 dms1981 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit c408c67 Jul 10, 2024
13 checks passed
@dms1981 dms1981 deleted the feature/7415-corporate-information-system-2 branch July 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants