Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚰️ Delete removed accounts #7849

Merged
merged 2 commits into from
Sep 5, 2024
Merged

⚰️ Delete removed accounts #7849

merged 2 commits into from
Sep 5, 2024

Conversation

ASTRobinson
Copy link
Contributor

@ASTRobinson ASTRobinson commented Sep 4, 2024

This PR tidies up previously removed/deleted accounts from the terraform/environments directory, this has been checked against the .json files in the environments directory and also the policies/environments/expected.rego file.

Accounts Affected:
data-platform-compute
hmpps-intelligence-management
remote-supervision
tariff

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/tariff


Running Trivy in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.


Running Trivy in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.


Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/tariff

*****************************

Running Checkov in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.

*****************************

Running Checkov in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.

*****************************

Running Checkov in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/tariff

*****************************

Running tflint in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/tariff

*****************************

Running Trivy in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.

*****************************

Running Trivy in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.

*****************************

Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/remote-supervision
terraform/environments/tariff


Running Trivy in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.


Running Trivy in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.


Running Trivy in terraform/environments/remote-supervision
Skipping folder terraform/environments/remote-supervision as it does not exist.


Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/remote-supervision
terraform/environments/tariff

*****************************

Running Checkov in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.

*****************************

Running Checkov in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.

*****************************

Running Checkov in terraform/environments/remote-supervision
Skipping folder terraform/environments/remote-supervision as it does not exist.

*****************************

Running Checkov in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/remote-supervision
terraform/environments/tariff

*****************************

Running tflint in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/remote-supervision
Skipping folder terraform/environments/remote-supervision as it does not exist.
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/data-platform-compute
terraform/environments/hmpps-intelligence-management
terraform/environments/remote-supervision
terraform/environments/tariff

*****************************

Running Trivy in terraform/environments/data-platform-compute
Skipping folder terraform/environments/data-platform-compute as it does not exist.

*****************************

Running Trivy in terraform/environments/hmpps-intelligence-management
Skipping folder terraform/environments/hmpps-intelligence-management as it does not exist.

*****************************

Running Trivy in terraform/environments/remote-supervision
Skipping folder terraform/environments/remote-supervision as it does not exist.

*****************************

Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

@ASTRobinson ASTRobinson marked this pull request as ready for review September 5, 2024 08:26
@ASTRobinson ASTRobinson requested a review from a team as a code owner September 5, 2024 08:26
Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Status checks fail because of folder deletion but this has to be accepted in this scenario.

@ASTRobinson ASTRobinson added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 8e69c63 Sep 5, 2024
25 of 41 checks passed
@ASTRobinson ASTRobinson deleted the accounts/tidy-up branch September 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants