Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go live date and docs #7905

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

robertsweetman
Copy link
Contributor

A reference to the issue / Description of it

Update go-live date for PlanetFM and slightly tweak the docs for exactly what to change

How does this PR fix the problem?

Adds the date

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

Very low risk

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

Nope

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@robertsweetman robertsweetman requested a review from a team as a code owner September 11, 2024 15:14
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

@github-actions github-actions bot added documentation Improvements or additions to documentation onboarding Tasks to onboard teams labels Sep 11, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsweetman robertsweetman added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 93d6912 Sep 11, 2024
17 checks passed
@robertsweetman robertsweetman deleted the TM/TM-470/add-start-date-pagerduty branch September 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants