-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New NAT Alarms core network services #7969
New NAT Alarms core network services #7969
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirm it is live_data and non_live_data.
alarm_name = "nat_packets_drop_count_${each.key}" | ||
comparison_operator = "GreaterThanThreshold" | ||
evaluation_periods = 5 | ||
threshold = "100" # Adjust this threshold as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The threshold value for the CloudWatch alarm should be a number, not a string. Please change the line to:
threshold = 100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed that now @sukeshreddyg
|
A reference to the issue / Description of it
As Part of issue NAT Alarms for Core network services account
#7724
we wanted to setup some new alarms for the NAT gateway in core-networking account
How does this PR fix the problem?
This PR add these alarms to cover both live and non-live vpc's
How has this been tested?
Please describe the tests that you ran and provide instructions to reproduce.
i have run the plan locally on my machine and the play runs correctly and produces the output required
Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
{Please write here}
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}