Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test account to the electronic-monitoring-data account #7998

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

pricemg
Copy link
Contributor

@pricemg pricemg commented Sep 20, 2024

A reference to the issue / Description of it

Electronic monitoring are going to be receiving data from external suppliers who will be pushing data to an S3 bucket. We want to test and ensure this connection is secure outside of our Production account.

How does this PR fix the problem?

It creates a test account where we can test suppliers sending dummy data before promoting to Prod.

We then have an action to exclude spinning up most infra in our test account as many things won't be needed.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

Not tested, just eyeballed config file update against other accounts.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

Original account request > #5833

@pricemg pricemg requested a review from a team as a code owner September 20, 2024 13:00
@github-actions github-actions bot added the onboarding Tasks to onboard teams label Sep 20, 2024
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@ASTRobinson ASTRobinson added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 6a62d45 Sep 20, 2024
49 checks passed
@ASTRobinson ASTRobinson deleted the pricemg-patch-2 branch September 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants