Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx.rst, mising reload, some more explanation #1280

Merged
merged 8 commits into from
Jun 27, 2023

Conversation

underdarknl
Copy link
Contributor

Some steps where not listed, and a bi tmore extra info might be useful

@underdarknl underdarknl requested a review from a team as a code owner June 23, 2023 12:33
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions

docs/source/technical_design/nginx.rst Outdated Show resolved Hide resolved
docs/source/technical_design/nginx.rst Outdated Show resolved Hide resolved
docs/source/technical_design/nginx.rst Outdated Show resolved Hide resolved
docs/source/technical_design/nginx.rst Outdated Show resolved Hide resolved
ammar92
ammar92 previously approved these changes Jun 26, 2023
@dekkers dekkers merged commit d93d741 into main Jun 27, 2023
4 checks passed
@dekkers dekkers deleted the underdarknl-nginx-docs-reload branch June 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants