-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create object history API #2074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donny Peeters <donny@bitestreams.com>
Signed-off-by: Donny Peeters <donny@bitestreams.com>
Signed-off-by: Donny Peeters <donny@bitestreams.com>
underdarknl
reviewed
Dec 1, 2023
underdarknl
reviewed
Dec 1, 2023
Signed-off-by: Donny Peeters <donny@bitestreams.com>
Done @underdarknl |
ammar92
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Just a few remarks, should be good to go soon
Donnype
commented
Dec 6, 2023
… model with snake casing. Signed-off-by: Donny Peeters <donny@bitestreams.com>
Signed-off-by: Donny Peeters <donny@bitestreams.com>
… feature/object-history-api # Conflicts: # octopoes/octopoes/xtdb/client.py # octopoes/tests/integration/test_api_connector.py
Signed-off-by: Donny Peeters <donny@bitestreams.com>
Done @ammar92 |
ammar92
approved these changes
Dec 6, 2023
underdarknl
approved these changes
Dec 6, 2023
Checklist for QA:
What works:There appears to be no impact in the UI. Onboarding flow works, adding an extra URL object works and this is also scanned. What doesn't work:N/a. Bug or feature?:N/a. |
jpbruinsslot
added a commit
that referenced
this pull request
Dec 6, 2023
* main: (25 commits) Create object history API (#2074) Bump actions/github-script from 6 to 7 (#2076) Installation manual for Windows (2) (#2096) Update howdoesitwork.rst (#2091) Add benchmarking script to the scheduler (#2071) Add fix-poetry-merge-conflict makefile command (#2088) Bump sphinx-rtd-theme from 1.2.2 to 2.0.0 (#2080) Lower quality level so the CI check doesn't fail (#2086) Update xtdb version in octopoes CI docker compose and docker-compose.release-example.yml (#2085) Name test nodes by testname instead of uuid (#2087) Upgrade to Pydantic v2 (#1912) Docs: add dependency installation commands for RHEL based systems (#2059) Fix/2072 (#2082) Feature/service to systems reports rocky (#2073) Update scheduler python packages (#2062) Add uvicorn back as non-dev dependency (#2053) Bump `cryptography` (#2070) Filter tree objects with depth=1 for Findings (#1982) Bump aiohttp from 3.8.6 to 3.9.0 in /boefjes (#2061) Translations update from Hosted Weblate (#2057) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an API representing XTDB's entity-history. This can be used to infer when objects were first and last seen (CC @Rieven). This would boil down to filtering the transaction history by "
doc is not None
" (since these are deletes, not PUT's) and filtering on valid_time. Then the valid time of the first transaction is the "first_seen" and the valid time of the last transaction is the "last_seen".Demo
The API:
Example transaction log json where I added then deleted
Network|internet
, then added it again:Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.