Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering on plugin_id for normalizers #3226

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Jul 10, 2024

Changes

Updated filtering on the queryparam plugin_id for normalizers. The correct "and" clause wasn't present. And this has been added now.

Issue link

No issue link

QA notes

  1. On main, go through the onboarding, create the organisation dev and create a scan for a domain
  2. On the command line issue the following:
$ curl 'http://localhost:8004/tasks?scheduler_id=normalizer-dev&task_type=normalizer&plugin_id=kat_dnssec_normalize'
  1. This should relay the following message:
{
  "detail": "error occurred while accessing the database [exception: An error occurred: 'str' object has no attribute 'field']"
}
  1. Checkout this branch and follow step 1 and 2 again

  2. No error should be relayed


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@jpbruinsslot jpbruinsslot added the mula Issues related to the scheduler label Jul 10, 2024
@jpbruinsslot jpbruinsslot self-assigned this Jul 10, 2024
@jpbruinsslot jpbruinsslot marked this pull request as ready for review July 10, 2024 15:08
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner July 10, 2024 15:08
@jpbruinsslot jpbruinsslot added the bug Something isn't working label Jul 10, 2024
@dekkers dekkers merged commit d77491e into main Jul 11, 2024
9 checks passed
@dekkers dekkers deleted the fix/mula/fix-normalizer-filtering branch July 11, 2024 11:15
jpbruinsslot added a commit that referenced this pull request Jul 16, 2024
* main: (31 commits)
  Refactor Task List and filters with error handlers for Scheduler  (#1957)
  Fix filtering on plugin_id for normalizers (#3226)
  Implement `structlog` (#3175)
  Gather BIT metrics [implementation] (#3122)
  Add observation data to observation table in OOI detail page (#3186)
  cve-2024-6387 from RickGeex (#3194)
  Recalculate bit when a config object changes (#3206)
  Use more concise regexes (#3181)
  Updated Django (#3217)
  Updated `zipp` (#3215)
  Feature/boefje normalizer config models (#3118)
  Updated `certifi` (#3209)
  Add pluginToggler.js to Aggregate Report (#3202)
  Update to Django 5.0 (#2939)
  Update Dockerfile, fix Sonarcloud issue (#3180)
  Better default list of world writable domains in CSP checker (#3165)
  Update 1.16 release notes (#3195)
  Remove non standard header findings and add deprecated headers findings (#3127)
  Fix/sonarcloud https redirect dockerfiles (#3185)
  Bump docker/build-push-action from 5 to 6 (#3164)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mula Issues related to the scheduler
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants