Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty normalizer results #3482

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Sep 6, 2024

Changes

Add an empty observation when nothing was found for an input ooi, to trigger deletion.

Issue link

Demo

QA notes

Please check deletion propagation for the SSL certificates (per the instructions of @noamblitz).


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner September 6, 2024 10:39
noamblitz
noamblitz previously approved these changes Sep 6, 2024
Copy link
Contributor

@noamblitz noamblitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue!

@noamblitz noamblitz changed the title Handle empty normalizer restults Handle empty normalizer results Sep 6, 2024
ammar92
ammar92 previously approved these changes Sep 6, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Tiny suggestion, but consider it approved.

boefjes/boefjes/job_handler.py Outdated Show resolved Hide resolved
@Donnype Donnype self-assigned this Sep 6, 2024
@Donnype Donnype added the bug Something isn't working label Sep 6, 2024
@Donnype Donnype dismissed stale reviews from noamblitz and ammar92 via fac3ea7 September 9, 2024 11:23
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Seems to work using the reproduction steps mentioned by @noamblitz.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 9942c9f into main Sep 10, 2024
9 checks passed
@underdarknl underdarknl deleted the fix/deletion-empty-normalizer-results branch September 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants