Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for creating a new Boefje #3540

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

madelondohmen
Copy link
Contributor

Changes

This PR adds some text to the creating_a_boefje.md documentation.

Issue link

Closes #3437


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made. // Only changes to the documentation
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen added the documentation Improvements or additions to documentation label Sep 16, 2024
@madelondohmen madelondohmen self-assigned this Sep 16, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner September 16, 2024 13:56
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just a few tiny remarks

@underdarknl underdarknl merged commit 0d86aec into main Sep 18, 2024
6 checks passed
@underdarknl underdarknl deleted the feature/update-boefje-documentation branch September 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update create boefje documentation
3 participants